Conversation
|
CI failure https://github.com/thesofproject/sof/actions/runs/14970782671/job/42051045218?pr=10000 should be fixed by #10001 |
src/ipc/ipc-common.c
Outdated
| #if CONFIG_GDBSTUB | ||
| if (ipc_enter_gdb) { | ||
| ipc_enter_gdb = false; | ||
| k_msleep(5); |
| static int ipc_glb_gdb_debug(struct ipc4_message_request *ipc4) | ||
| { | ||
| #if CONFIG_GDBSTUB | ||
| ipc_enter_gdb = true; |
There was a problem hiding this comment.
we should log this entry as it comes from host IPC
lyakh
requested review from
RanderWang,
bardliao,
dbaluta,
kv2019i,
lbetlej,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
|
You have PR number 10000 !!!! |
@marcinszkudlinski I do (since more than a month ;-) )! Am I getting a prize? ;-) |
kv2019i
changed the title
kv2019i
changed the title
|
|
||
| # GDB stub | ||
|
|
||
| CONFIG_GDBSTUB=y |
There was a problem hiding this comment.
This overlay is used in our SOF driver CI, so gdb stub will be enabled. Probably ok and even preferred as this will get a minimal coverage in CI for the gdb build.
There was a problem hiding this comment.
yes, that's the intension
|
@lyakh This seems ready to go except for the mandatory CI check fail. Any idea why that is failing? I don't see anything in the PR that would break existing tests. |
Python versions. |
|
@lyakh can you rebase - btw not seen the Python failure in other PRs. |
@lgirdwood Python failures aren't seen in most other PRs because they don't update the Zephyr version. So we need to fix that issue first, then I can rebase and we can merge |
Add an IPC4 message type to instruct the firmware to enter the GDB stub. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Need to decide if old XTOS GDB stub should be removed and add support for IPC4. Signed-off-by: Noah Klayman <noah.klayman@intel.com>
To avoid timed out IPC on the host side, enter the GDB stub only after replying to the IPC. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add suppoprt for the new IPC4 GDB enter message. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
By default enable the GDB stub when building the debug configuration. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
force-pushed
the
gdb
branch
2 times, most recently
from
2824d1e to
dd938e1
Compare
lyakh
changed the title
5 participants
This respins nklayman@cbb3f4d to add GDB stub support to SOF. With this an IPC can be sent to SOF to enter the GDB stub, after which a Linux driver debugging interface from thesofproject/linux#5411 can be used to communicate with the stub over a memory window. Both IPC3 and IPC4 are supported. So far only cAVS 2.5 is supported.